D19311: Add navigation history to forward/back buttons
Nathaniel Graham
noreply at phabricator.kde.org
Wed Apr 24 18:00:59 BST 2019
ngraham added a comment.
In D19311#454150 <https://phabricator.kde.org/D19311#454150>, @hallas wrote:
> In D19311#450238 <https://phabricator.kde.org/D19311#450238>, @ngraham wrote:
>
> > The Breeze patch looks sane. I'm torn on whether or not adding the new style to KWidgetsAddons makes sense though. Couldn't Dolphin just set the new `_kde_toolButton_noMenuArrow` on just these buttons?
>
>
> I don't think I can, because the buttons are not created directly by Dolphin, but instead they are created by `QToolbar` using the `KToolBarPopupAction::createWidget` function. So therefore I think we would either need to handle it in `KWidgetAddons` or maybe do a subclass of `KToolBarPopupAction` in Dolphin which adds this property, what do you guys think?
Ah yeah, that makes sense. A subclass in Dolphin that just adds that property probably makes sense.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D19311
To: hallas, #dolphin, ngraham, elvisangelaccio, #vdg
Cc: richardl, ognarb, david.fontanals, abetts, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190424/a7a0b766/attachment.htm>
More information about the kfm-devel
mailing list