D16648: Open externally called files/directories in new tabs
Alexander Saoutkin
noreply at phabricator.kde.org
Wed Apr 24 14:37:21 BST 2019
feverfew added a comment.
In D16648#450590 <https://phabricator.kde.org/D16648#450590>, @davidedmundson wrote:
> activateWindow works if and only if your X startup info is correct.
>
> When you launch dolphin through a UI (on gnome or Plasma) you will see an extra environment variable on your dolphin process.
>
> DESKTOP_STARTUP_ID=David-Desktop;1555336591;362121;16299_TIME219914845
>
> Qt normally handles this internally.
>
> If you then call into an existing dolphin you need to pass this and import it the other side before calling window->activate().
> See KStartupInfo or QX11Extras::setAppTime
>
> Plasma isn't really involved.
Does this also apply if dolphin is called via the terminal? If not then I think we should stick with `forceActiveWindow`, otherwise I'm happy to make the changes necessary.
In D16648#452719 <https://phabricator.kde.org/D16648#452719>, @fbg13 wrote:
> Currently opening an already open path creates a new tab.
> I think it's better to just activate the existing tab.
Good point. Happy to implement this if everyone else is.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D16648
To: feverfew, #dolphin, elvisangelaccio
Cc: fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190424/af8cbc2b/attachment.htm>
More information about the kfm-devel
mailing list