D20024: Fixes crash when hiding devices

David Hallas noreply at phabricator.kde.org
Mon Apr 22 18:47:27 BST 2019


hallas marked an inline comment as done.
hallas added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kstandarditem.cpp:117-118
> Feel free to try :)

Ok, I have now changed `KStandardItem` to derive from `QObject` instead, and then call `deleteLater` when removing an item. This also fixes the crash and I think it is a _much_ nicer fix. Also this removes some of the custom parent/children code from `KStandardItem`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20024

To: hallas, #dolphin, elvisangelaccio
Cc: ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190422/d7bb532c/attachment.htm>


More information about the kfm-devel mailing list