D19926: Add Bookmark Handling

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> hallas wrote in dolphinbookmarkhandler.cpp:39-41
> I am not quite sure what to do in this case. When I look in Konqueror or Okular, which has very similar bookmark handling, then this case is not handled at all. In the case here, we would end up trying to create `/dolphin` (which would probably fail) and then append `/bookmarks.xml` and use that. Then `KBookmarkManager` would end up trying to read/write that file, which would also fail, so you wouldn't get your bookmarks persisted. I don't know if that is all bad :/

We could at least print a qWarning() so that the users might have a chance to figure out why their bookmarks are not saved.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19926

To: hallas, #dolphin, elvisangelaccio, ngraham
Cc: loh.tar, cfeck, hein, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190422/16926bac/attachment.htm>