D20525: [InformationPanel] Use the new inline configuration mode

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Apr 22 12:50:43 BST 2019


bruns added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in informationpanelcontent.cpp:122-124
> These 3 lines could go in a dedicated function which we could call from both lambdas, to avoid code duplication. Or it could even be a private slot connected to `QDialogButtonBox::clicked`.

I don't think an extra level of indirection makes the code easier to understand ...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190422/12936573/attachment.htm>


More information about the kfm-devel mailing list