D20660: Fix missing update of file name label in information panel without preview

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Apr 18 13:41:01 BST 2019


bruns created this revision.
bruns added reviewers: Dolphin, elvisangelaccio, meven, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The file name label was only updated when the preview was shown, after
  the function was moved into a conditional section. This is a regression
  caused by commit 405aa4878f75 <https://phabricator.kde.org/R318:405aa4878f755b06123711f4cdbc8507cc15c18e> ("[InformationPanel] Hide the video when the
  preview is disabled, avoid computing the preview when it is disabled").

TEST PLAN
  Hide the preview in dolphin's information panel
  Hover different files, the name label reflects the hovered file again

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20660

AFFECTED FILES
  src/panels/information/informationpanelcontent.cpp

To: bruns, #dolphin, elvisangelaccio, meven, ngraham
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190418/226dfb8c/attachment.htm>


More information about the kfm-devel mailing list