D16648: Open externally called files/directories in new tabs
Alexander Saoutkin
noreply at phabricator.kde.org
Mon Apr 15 13:07:00 BST 2019
feverfew added a comment.
In D16648#449696 <https://phabricator.kde.org/D16648#449696>, @elvisangelaccio wrote:
> This made me think: what about non-plasma systems?
> e.g. GNOME doesn't even have a taskbar, what's gonna happen there?
Exactly. I have a feeling this will be a hard thing for us to send to Plasma for fix. How would Plasma be able to understand if an `activateWindow` was actioned by a user or by say, a background process? In our case I believe it is ok to use `KWindowSystem::forceActivateWindow` as it is only invoked when specifically requested by the user (i.e. only invoked when someone executes the dolphin executable or asks to open a folder/item via the `org.freedesktop.FileManager1.ShowFolders/ShowItems` DBus method. Note that a big inspiration in implementing this feature was derived from how Okular does it, in particular this snippet (https://github.com/KDE/okular/blob/a16c0be349dd0484f5d8e6174db594a52779c585/shell/shell.cpp#L488-L491).
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D16648
To: feverfew, #dolphin, elvisangelaccio
Cc: davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190415/77109d81/attachment.htm>
More information about the kfm-devel
mailing list