D16648: Open externally called files/directories in new tabs

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dbusinterface.cpp:47-49
> +    const auto serviceName = QStringLiteral("org.kde.dolphin-%1").arg(
> +        QCoreApplication::applicationPid()
> +    );

This could be in a single line ;)

> feverfew wrote in dolphinmainwindow.cpp:199
> The problem with `activateWindow()` is that it doesn't raise the file manager - only a yellow background is put on the taskbar of the dolphin instance that the tab was opened to. In the current version of Dolphin, when we ask to open a folder in an external application a new instance of dolphin is opened, hence why it is raised to the top. For me not being able to raise the window to the top creates a bad UX as usually they want to see the folder they opened straight away, instead of having to click for the file manager after they've asked to see the folder. I think we should open this up for discussion.

Well, the documentation is pretty clear:

  There are two ways how to activate a window, by calling activateWindow() and forceActiveWindow(). Generally, applications shouldn't make attempts to explicitly activate their windows, and instead let the user to activate them. In the special cases where this may be needed, applications should use activateWindow(). Window manager may consider whether this request wouldn't result in focus stealing, which would be obtrusive, and may refuse the request.
  
  The usage of forceActiveWindow() is meant only for pagers and similar tools, which represent direct user actions related to window manipulation. Except for rare cases, this request will be always honored, and normal applications are forbidden to use it.

If this results in a bad UX, it should be probably addressed in plasma.

> global.h:49
> +     */
> +    bool attachToExistingInstance(const QStringList urls, bool openFiles, bool splitView);
>  

Missing pass-by-const-reference for `urls`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16648

To: feverfew, #dolphin, elvisangelaccio
Cc: davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190414/5ecf17e8/attachment.htm>