D16648: Open externally called files/directories in new tabs

[Alexander Saoutkin]

feverfew marked 9 inline comments as done.
feverfew added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:199
> Please use `KWindowSystem::activateWindow()` instead. Normal applications are not supposed to call `forceActiveWindow()`.
> 
> And I'd call this method `activateWindow()` as well, rather than `tryRaise()`.

The problem with `activateWindow()` is that it doesn't raise the file manager - only a yellow background is put on the taskbar of the dolphin instance that the tab was opened to. In the current version of Dolphin, when we ask to open a folder in an external application a new instance of dolphin is opened, hence why it is raised to the top. For me not being able to raise the window to the top creates a bad UX as usually they want to see the folder they opened straight away, instead of having to click for the file manager after they've asked to see the folder. I think we should open this up for discussion.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16648

To: feverfew, #dolphin, elvisangelaccio
Cc: ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190413/058938cc/attachment.htm>