D20396: Don't show "Open With" menu items for empty directories

Nathaniel Graham noreply at phabricator.kde.org
Mon Apr 8 23:07:14 BST 2019


ngraham created this revision.
ngraham added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Any app that registers itself as able to open directories generally can't do anything
  useful with an empty directory. So, don't show the Open With menu items for them.

TEST PLAN
  Before: F6759793: Before.png <https://phabricator.kde.org/F6759793>
  
  After: F6759794: After.png <https://phabricator.kde.org/F6759794>
  
  The Open With items still appear for non-empty directories.

REPOSITORY
  R318 Dolphin

BRANCH
  dont-show-open-with-items-on-empty-dir (branched from Applications/19.04)

REVISION DETAIL
  https://phabricator.kde.org/D20396

AFFECTED FILES
  src/dolphincontextmenu.cpp

To: ngraham, #dolphin
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190408/f43887ce/attachment.htm>


More information about the kfm-devel mailing list