D20357: Make buttons in seach bar nicer (icon, tooltip, autoselect)

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinsearchbox.cpp:90
>  
> -    QString location = url.fileName();
> +    auto cleanedUrl = url.adjusted(QUrl::RemoveUserInfo | QUrl::StripTrailingSlash);
> +    QString location = cleanedUrl.fileName();

`const`

> dolphinsearchbox.cpp:143
>              // mean "the whole harddisk" instead of "my home folder" when
>              // selecting the "Everywhere" button.
>              encodedUrl = QDir::homePath();

Please update this comment ("Everywhere" should be removed).

> dolphinsearchbox.cpp:405
>  
> -    // Create "From Here" and "Everywhere"button
> +    // Create "From Here" and "Everywhere" buttons
>      m_fromHereButton = new QToolButton(this);

Please update this comment as well.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20357

To: bruns, #dolphin, #kde_applications, ngraham, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190407/eeccfa14/attachment.htm>