D20357: Make buttons in seach bar nicer (icon, tooltip, autoselect)

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Dolphin, KDE Applications, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The "Everywhere" button actually selects the home directory, so use
  an appropriate label ("My files") and add a "user-home" icon.
  
  Pre-select the right button when entering search, depending on the location
  where the "Find ..." action was triggered.
  
  Add tooltips for both buttons, stating where to look for files. Most
  importantly, this includes the full path for "From here".
  
  Do not hide the buttons in case the url is non-local, as it is confusing:
  
  1. The state depends on the previous search. When the user hits "Find"
  
  when browsing e.g an SMB share, the search was probably in the home dir.
  
  2. The current search location was hidden
  3. The user may want to do a local search, give the option to do so.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20357

AFFECTED FILES
  src/search/dolphinsearchbox.cpp

To: bruns, #dolphin, #kde_applications, ngraham
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190407/18e70d3d/attachment.htm>