D19311: Add navigation history to forward/back buttons

[Elvis Angelaccio]

elvisangelaccio added a comment.


  About the UI: I'd also be in favor of not showing the arrows. It's not just Falkon that doesn't show them, but also Firefox and Chrome.

INLINE COMMENTS

> dolphinmainwindow.cpp:1682
>  }
> -

Unrelated whitespace change

> middleclickactioneventfilter.cpp:56-70
> +            QMenu *menu = qobject_cast<QMenu *>(watched);
> +            if (menu) {
> +                QAction *action = menu->actionAt(me->pos());
> +                if (action) {
> +                    if (event->type() == QEvent::MouseButtonPress) {
> +                        m_lastMiddlePressedAction = action;
> +                    } else if (event->type() == QEvent::MouseButtonRelease) {

This could maybe go as the `else` branch of `if (toolBar)` ?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19311

To: hallas, #dolphin, ngraham, elvisangelaccio, #vdg
Cc: ognarb, david.fontanals, abetts, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190406/42017953/attachment.htm>