D19926: Add Bookmark Handling

[David Hallas]

hallas added a comment.


  In D19926#439515 <https://phabricator.kde.org/D19926#439515>, @ngraham wrote:
  
  > In D19926#439169 <https://phabricator.kde.org/D19926#439169>, @hallas wrote:
  >
  > > In D19926#437313 <https://phabricator.kde.org/D19926#437313>, @ngraham wrote:
  > >
  > > > Ah, that was the secret sauce, thanks!
  > > >
  > > > This generally works quite well and is a very nice feature. One request: can you disable the Bookmark Tabs As Folder... menu item when there's only one tab open? Also yeah, we should probably consider putting this somewhere in the Control menu too.
  > >
  > >
  > > I haven't found a way where I can conditionally remove the Bookmark Tabs As Folder... :( I would need to change the API of KBookmarks to do this. Any ideas for this are more than welcome :D
  >
  >
  > Ehh, this is probably fine for now then. :) Though it would be nice to look into that.
  
  
  I ended up looking at it anyway ;) I have pushed this D20209 <https://phabricator.kde.org/D20209> which extends KBookmarks with support for communicating if you actually have tabs open, and if not the Bookmark Tabs As Folder... entry is not added

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19926

To: hallas, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190402/0d9e87bb/attachment.htm>