D15774: Track search mode in variable

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Sep 26 15:53:51 BST 2018


broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Rather than relying on a widget being visible which might not be the case for e.g. non-active tabs

TEST PLAN
  Noticed while testing D15772 <https://phabricator.kde.org/D15772> that when in a search, pressing Ctrl+T that would open the same search in a new tab would show the url instead because by the time the tab is added and its title evaluated the search box might not have been polished/made visible
  
  - Ctrl+F → type something → Ctrl+T → now the tab title is correct

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15774

AFFECTED FILES
  src/dolphinviewcontainer.cpp
  src/dolphinviewcontainer.h

To: broulik, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180926/fd8235f8/attachment.htm>


More information about the kfm-devel mailing list