D7647: Two clicks on file/folder to rename

[Wolfgang Bauer]

wbauer added a comment.


  In D7647#330478 <https://phabricator.kde.org/D7647#330478>, @elvisangelaccio wrote:
  
  > In D7647#328392 <https://phabricator.kde.org/D7647#328392>, @wbauer wrote:
  >
  > > This apparently caused regressions as I noticed:
  > >
  > > 1.) Long-clicking on a selected file now triggers inline renaming in single-click mode too.
  > >  Or was that intentional? The summary states this though:
  >
  >
  > That's definitely not intentional. Is there a bugreport for this?
  
  
  Not that I am aware of.
  And I didn't file one because I wasn't sure if it was intentional or not (a wrong commit message is not really a reason for a bug report, is it? ;-) ).
  
  Actually, I'd find it quite ok to be able to rename files by long-clicking, even in single-click mode.
  I don't really see why this should be restricted to already selected files though (long-click should be enough of protection against accidently triggering it I think).
  No strong opinion on that though.
  
  In D7647#330816 <https://phabricator.kde.org/D7647#330816>, @akrutzler wrote:
  
  > I am able to reproduce them both. @wbauer  do you want to fix them? If not, I can spend some time on it. :)
  
  
  TBH, I would prefer if you'd try to fix it.
  I'm not really familiar with the code (e.g. I don't know yet what m_dragging is used for originally...).
  I was going to investigate further, but haven't find the time for that yet, you can see my findings so far in https://bugs.kde.org/show_bug.cgi?id=398375 though.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, rkflx
Cc: kfm-devel, wbauer, rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180924/b18ecac5/attachment.htm>