D15583: [Balooctl] fix directory parent check

[Stefan Brüns]

bruns added a comment.


  In D15583#330119 <https://phabricator.kde.org/D15583#330119>, @ngraham wrote:
  
  > In D15583#330085 <https://phabricator.kde.org/D15583#330085>, @bruns wrote:
  >
  > > I think the whole `startsWith` is flawed - it should be possible to have a e.g. "/home/user/foo/bar" include when "/home/user/foo" has been excluded.
  >
  >
  > Hmm, I'm not sure how much that matches the user expectation. If a folder is explicitly marked as excluded, I think it's most commonly understood that all its sub-folders would also be excluded.
  >
  > I could see the case for allowing this behavior to be explicitly overridden by an advanced user who marks `~/foo/` as excluded and then later marks `~foo/bar/` as included, but that would be material for another patch I think.
  
  
  If I read the unit tests correctly (https://phabricator.kde.org/source/baloo/browse/master/autotests/unit/file/fileindexerconfigtest.cpp), this is already supported. You just can not do it via balooctl.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180922/684cd1ca/attachment.htm>