D15147: Correctly save behaviourOnLaunch

[Wolfgang Bauer]

wbauer added inline comments.

INLINE COMMENTS

> confirmationssettingspage.cpp:100
> +    } else {
> +        scriptExecutionGroup.writeEntry("behaviourOnLaunch", "dontAsk");
>      }

Judging from the KIO source code, the possible values for this option seem to be "alwaysAsk", "open" and "execute" though.
See also https://bugs.kde.org/show_bug.cgi?id=371837, that's mentioned there  as well.

And if I read the code correctly, "dontAsk" would actually have the same result as "open", not "execute". But the option in dolphin's setting is labelled "Executing scripts or desktop files", so this fix is actually wrong IMHO.

(Ideally dolphin should probably offer all three options in its settings, that's more than a simple bugfix though.)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15147

To: davidedmundson, #dolphin, ngraham, elvisangelaccio
Cc: wbauer, ngraham, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180918/286e2f63/attachment.htm>