D15579: RFC: Use full-sized highlight

Nathaniel Graham noreply at phabricator.kde.org
Mon Sep 17 17:07:59 BST 2018


ngraham accepted this revision as: VDG.
ngraham added a comment.


  Technically that is correct--Breeze widget theme vs Breeze Plasma theme. But from a user perspective, it's a needless inconsistency. The fact that Folder view is a Plasma widget rather than an extension of Dolphin is an implementation detail lost on people who aren't power users or developers. And even for someone who understands the distinction, they might (not unreasonably) think, //Why should the Breeze widget theme look different from the Breeze Plasma theme? Aren't they both Breeze?//
  
  Anyway, that's another issue, and for the purposes of this patch, I'm a +1. Consistency with the file open/save dialogs is good enough for now, and we can investigate rounding the corners in the widget theme later if necessary.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15579

To: broulik, #dolphin, #vdg, elvisangelaccio, fvogt
Cc: abetts, ngraham, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180917/85e3fcf5/attachment.htm>


More information about the kfm-devel mailing list