Fwd: Dolphin: Close unfocused view when toggling off split view

[Nate Graham]

Re-sending my response:

Hello Angelo,
Thanks for the patch! Please submit it to phabricator.kde.org, following 
the instructions available here: 
https://community.kde.org/Infrastructure/Phabricator

However please note that this issue has attracted a fair share of 
patches before (e.g. https://phabricator.kde.org/D7014), and there is a 
lengthy discussion on the subject in 
https://bugs.kde.org/show_bug.cgi?id=312834. Some people seem to prefer 
that the inactive view is closed, some prefer the active, and some want 
the right one to always get closed no matter what. Others are against 
adding an option to control the behavior, so the discussion has sort of 
gotten stuck.

My personal preference is for adding close buttons to each pane of the 
split view so that people can click on the close button for the pane 
they want to close.

Nate



On 09/12/2018 02:10 PM, Angelo Oliveira Jr. wrote:
> Note: I'm re-sending because I wasn't subscribed at time. I didn't know 
> I had to do it at time.
> 
> Hello!
> 
> The Dolphin File Manager acts oddly when closing split view, instead of 
> closing the unfocused view (which in effect is the one you want to 
> remove), It closes the focused view, going against to what most file 
> managers does, if you aren't used to it you are gonna have to still 
> think for some time before pressing F3 (default split view toggle key), 
> which may lead to an unproductive and uncomfortable user experience. 
> Luckily I already made a patch which solves this, It adds a "Close 
> focused split view when toggling off" to the configuration options and 
> is enabled by default since is what most KDE users may want.
> 
> What made me do it was this thread: 
> https://forum.kde.org/viewtopic.php?f=223&t=151449
> 
> The patch is a 4 files overwrite and was made on top of the latest Git 
> today, I don't know how to contribute to KDE apps code, it's my first 
> time so I'm sending this email, I expect my changes become available in 
> future versions of Dolphin, otherwise, people who wants this change will 
> have to relay on alternative AUR/PPA in case the rejection.
> 
> The patch is attached with the mail, thanks for the attention!