D15539: Keep org.freedesktop.FileManager1 registered across processes

David Edmundson noreply at phabricator.kde.org
Sat Sep 15 18:00:25 BST 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently if someone starts 2 dolphins, the second cannot register
  org.freedesktop.FileManager1 meaning and when the first dolphin quits,
  no-one has it registered.
  
  It doesn't cause a huge problem right now as we just dbus-activate a new one if
  needed, but it means the behaviour is a bit inconsistent and
  non-optimal.
  
  DBus has a system to queue names, meaning that as long as any dolphin is
  running this name is owned by one of the processes.
  
  Also this patch registers the service after the object which is
  technically safer.

TEST PLAN
  Ran d-feet
  Opened 2 dolphins, closed the first
  Service was still registered and the PID of the owning process changed.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15539

AFFECTED FILES
  src/dbusinterface.cpp

To: davidedmundson, #dolphin
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180915/5535448f/attachment.htm>


More information about the kfm-devel mailing list