D15237: [ViewProperties] Check part of home first before doing file system stuff

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> viewproperties.cpp:71-73
> +            // Check if the directory is writable and check if the ".directory" file exists and
> +            // is read- and writable.
> +            // Also check size of directory > 0 before accessing files inside it (stale mount)

I'd just remove these comments, because they are a bit confusing (and we already have a better comment at the top of the if-else chain).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15237

To: broulik, #dolphin, elvisangelaccio, lbeltrame
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180915/257f5f1c/attachment.htm>