D15516: Don't set window icon in daemon mode

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Sep 14 23:00:06 BST 2018


broulik created this revision.
broulik added reviewers: Dolphin, davidedmundson.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Creating an icon requires setting up a `KIconLoader` which in turn loads and processes icon themes, accounting to 10% of the daemon's startup time.
  All the daemon mode does is start new Dolphin processes, it doesn't show any windows.

TEST PLAN
  Should also save some ram but didn't notice any changes there
  
  - Dolphin windows still have a window icon
  - Doing "open containing folder" in an app for the first time feels quicker
  
  (imho the "daemon" should quit after having fullfilled the dbus activation request but that's an unrelated issue)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15516

AFFECTED FILES
  src/main.cpp

To: broulik, #dolphin, davidedmundson
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180914/a73ccfc4/attachment.htm>


More information about the kfm-devel mailing list