D15507: [MountPointObserverCache] Update remote and slow mounts less frequently

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> mountpointobservercache.cpp:58
>  {
> +    bool isSlow = false;
> +

Maybe true will be better.

> mountpointobservercache.cpp:71
>              // be able to retrieve information about the url.
>              cachedObserverUrl = url;
>          }

Here will be isSlow = false

> mountpointobservercache.cpp:86-87
>  
> -        if (!m_updateTimer->isActive()) {
> -            m_updateTimer->start(10000);
> +        if (!isSlow) {
> +            isSlow = (KProtocolInfo::protocolClass(cachedObserverUrl.scheme()) != QLatin1String(":local"));
> +        }

It can be removed

> mountpointobservercache.cpp:114
> +        m_fastUpdateTimer->stop();
> +        m_slowUpdateTimer->start();
>      }

You mean stop ? If you do single shot timer fit better, you don't need to check it's active and it don't need to stop.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15507

To: broulik, #dolphin, elvisangelaccio, sitter
Cc: anthonyfieroni, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180914/7e6a0d4f/attachment.htm>