D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Sep 10 12:41:43 BST 2018


broulik created this revision.
broulik added reviewers: Dolphin, ngraham.
broulik requested review of this revision.

REVISION SUMMARY
  When there is only one thumbnail it is painted larger. This pixmap is always generated, even if we ended up creating more than one thumbnail.
  This patch makes it remember the first valid thumbnail and paints the larger pixmap only as needed.

TEST PLAN
  Thumbnails of folders with no, one, or multiple previews are still rendered correctly.
  Saves up to 1 second generating the thumbnails here, however, I didn't really notice a huge impact in real world testing

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15402

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: broulik, #dolphin, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180910/57603760/attachment.htm>


More information about the kfm-devel mailing list