D15387: Do use QIcon::Selected for non-icon view

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Sep 9 19:56:55 BST 2018


broulik created this revision.
broulik added reviewers: Dolphin, VDG, fvogt.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Fixes a regression introduced by not using the selected state.
  The views other than icon view actually do have a proper highlighted background

TEST PLAN
  Fixes Places panel icons not turning white when selected
  Before
  F6246137: Screenshot_20180909_205550.png <https://phabricator.kde.org/F6246137>
  F6246138: Screenshot_20180909_205554.png <https://phabricator.kde.org/F6246138>
  After
  F6246136: Screenshot_20180909_205513.png <https://phabricator.kde.org/F6246136>
  F6246134: Screenshot_20180909_205449.png <https://phabricator.kde.org/F6246134>
  Icon view still fine
  F6246146: Screenshot_20180909_205633.png <https://phabricator.kde.org/F6246146>

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15387

AFFECTED FILES
  src/kitemviews/kstandarditemlistwidget.cpp

To: broulik, #dolphin, #vdg, fvogt
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180909/5b245a39/attachment.htm>


More information about the kfm-devel mailing list