D15069: Make thumbnail frame-and-shadow drawing criteria match those of the file dialog

[Kai Uwe Broulik]

broulik added a comment.


  Sweet!

INLINE COMMENTS

> kfileitemmodelrolesupdater.cpp:499
> +    if (!pixmap.hasAlpha() &&
> +        (m_iconSize.width() > KIconLoader::SizeSmallMedium &&
> +         m_iconSize.height() > KIconLoader::SizeSmallMedium)) {

Those parentheses are superfluous as you just do a conjunction for all of them; also move the operator to the beginning of the line

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15069

To: ngraham, #dolphin, broulik, elvisangelaccio
Cc: markg, anthonyfieroni, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180905/488f13f4/attachment.htm>