D15278: Close Dolphin if last tab closed

Nathaniel Graham noreply at phabricator.kde.org
Wed Sep 5 00:21:18 BST 2018


ngraham accepted this revision.
ngraham added a subscriber: elvisangelaccio.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great. Tested in a number of ways and couldn't find any behavioral bugs or regressions. One thing to note is that the menu item "Close tab" that bears the keyboard shortcut will still be visible when there's only a single tab, but I don't really think this is a problem, and in fact may be a good thing as it will let people know that this feature exists.
  
  I'm good with this now, but let's see what @elvisangelaccio and/or other #dolphin <https://phabricator.kde.org/tag/dolphin/> folks think before we land it. Thanks again for the patch!

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15278

To: feverfew, #dolphin, ngraham
Cc: elvisangelaccio, ngraham, #dolphin, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180904/f557d4b0/attachment.htm>


More information about the kfm-devel mailing list