D15278: Fix BUG:397101

Nathaniel Graham noreply at phabricator.kde.org
Tue Sep 4 21:45:06 BST 2018


ngraham added a comment.


  Thanks so much for the patch! I'll test it out later today. In the meantime, Can you give the title a human-friendly explanation, rather than "Fix BUG:397101", to follow commit message best practices? See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
  
  Also, `BUG: 397101` goes on its own line in the Description section.

INLINE COMMENTS

> dolphinmainwindow.cpp:1049
>      closeTab->setText(i18nc("@action:inmenu File", "Close Tab"));
> -    closeTab->setEnabled(false);
>  

Since `true` is the default state, we don't need to explicitly set it to true, so this line can just be deleted now.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15278

To: feverfew, #dolphin
Cc: ngraham, #dolphin, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180904/ad0dc461/attachment.htm>


More information about the kfm-devel mailing list