D15266: [DolphinContextMenu] Use the view's already existing root KFileItem
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Sep 4 13:42:43 BST 2018
broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.
REVISION SUMMARY
Saves creating a new `KFileItem` from scratch which `stat`s the file.
Only when the root item isn't available (as can happen when you're currently looking at an non-existing directory) will it create a new `KFileItem`
TEST PLAN
Context menu still works fine
Haven't actually encountered a case where `m_baseUrl` was different from the root url
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D15266
AFFECTED FILES
src/dolphincontextmenu.cpp
To: broulik, #dolphin, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180904/7ef08b4f/attachment.htm>
More information about the kfm-devel
mailing list