D15260: [KStandardItemListWidget] Round to icon size before applying scaling

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise for 22px icons on high dpi we will request either the wrong icons or scale them needlessly.
  Dolphin requests a pixmap of 22px, this is then multiplied by dpr resulting in 44 which isn't a valid icon size (only 32 or 48 are). Moreover, we will also hit the path where it will scale the pixmap to a proper icon size resulting in blurry icons (and a performance penalty).

TEST PLAN
  stable branch 
  Before
  F6234199: Screenshot_20180904_085627.png <https://phabricator.kde.org/F6234199>
  After
  F6234201: Screenshot_20180904_085645.png <https://phabricator.kde.org/F6234201>

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15260

AFFECTED FILES
  src/kitemviews/kstandarditemlistwidget.cpp

To: broulik, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180904/eec9c899/attachment.htm>