D15255: Don't use QIcon::Selected state for selected icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, VDG, elvisangelaccio, fvogt.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This causes selected monochrome Breeze icons to turn white as this state is meant for when the icon is actually painted ontop of e.g. a blue highlighted bar.
  Since the advanced icon configuration (where you could choose a custom hint color and other effects) has been removed in Plasma 5.13 and more importantly the fact that Dolphin always tints the icon in the highlight color disregarding any custom icon effects settings this is an acceptable change.

TEST PLAN
  Changed icon size to 16px, selected a folder, folder icon was still there. You can hardly see the blue tinting with the 1px outline icons, though
  Before
  F6233549: Screenshot_20180903_234454.png <https://phabricator.kde.org/F6233549>
  After
  F6233550: Screenshot_20180903_234531.png <https://phabricator.kde.org/F6233550>

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15255

AFFECTED FILES
  src/kitemviews/kstandarditemlistwidget.cpp

To: broulik, #dolphin, #vdg, elvisangelaccio, fvogt
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180903/1b2120cc/attachment.htm>