D7647: Two clicks on file/folder to rename

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D7647#328392 <https://phabricator.kde.org/D7647#328392>, @wbauer wrote:
  
  > This apparently caused regressions as I noticed:
  >
  > 1.) Long-clicking on a selected file now triggers inline renaming in single-click mode too.
  >  Or was that intentional? The summary states this though:
  >
  > > This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled.
  >
  >   In any case, I'd find this confusing as it only happens with selected files, not unselected ones.
  >   
  >
  > 2.) Dragging files can trigger inline editing too now, in both single- and double-click mode. (and even worse, it seems this can even cause unrelated files to be renamed to something completely different due to https://bugs.kde.org/show_bug.cgi?id=334533)
  >  See https://bugs.kde.org/show_bug.cgi?id=398375
  >
  > Reverting this change fixes both.
  
  
  For the record, the second issue was fixed in D15904 <https://phabricator.kde.org/D15904>. D16460 <https://phabricator.kde.org/D16460> fixes the first one instead.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, rkflx
Cc: kfm-devel, wbauer, rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181027/3123c1ba/attachment.htm>