D15278: Close Dolphin if last tab closed

Elvis Angelaccio noreply at phabricator.kde.org
Sat Oct 27 10:22:31 BST 2018


elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  In D15278#348352 <https://phabricator.kde.org/D15278#348352>, @ngraham wrote:
  
  > Yeah, I'm okay with it. Anyway, looking again for guidance, the HIG says that we shouldn't dynamically change menu items' labels:
  >
  > > https://hig.kde.org/components/navigation/menubar.html#appearance
  > >  Do not change menu items’ labels dynamically.
  >
  >
  
  
  Ah that's a good point.
  
  Nevermind then. Also, the menubar is hidden by default, I can live with this.
  
  @feverfew Are you going to patch all the other applications that use tabs? ;)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15278

To: feverfew, #dolphin, ngraham, #vdg, elvisangelaccio
Cc: thsurrel, svenmauch, abetts, elvisangelaccio, ngraham, #dolphin, kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181027/fb6ce35c/attachment.htm>


More information about the kfm-devel mailing list