D16413: Add a keyboard shortcut to create file

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> CMakeLists.txt:11
>  set(QT_MIN_VERSION "5.8.0")
> -set(KF5_MIN_VERSION "5.43.0")
> +set(KF5_MIN_VERSION "5.52.0")
>  

FYI: there is no time for KF5 5.52 (released on November 10th) in Applications 18.12 (dependency freeze is on November 8th).

If you want to ship this feature with 18.12, we'll have to go with `#ifdef`s

> dolphinviewactionhandler.h:103
> +     */
> +    void createFile();
> +

Please call it `createFileTriggered()` (I just pushed a patch that renames the `createDirectory()` signal).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16413

To: thsurrel, #dolphin, #plasma, #vdg
Cc: elvisangelaccio, kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181024/d2304a9a/attachment.htm>