D16353: Change color(red) of status bar in space info when storage exceeds 80%
Sourabh Sharma
noreply at phabricator.kde.org
Sun Oct 21 17:08:33 BST 2018
sourabhboss added a comment.
In D16353#346792 <https://phabricator.kde.org/D16353#346792>, @pino wrote:
> Not sure why I was added as reviewer... anyway:
>
> - no need to use `this->` to call own class members, unless there is a conflict (which does not look like)
> - please never hardcode colors! use `KColorScheme` instead
> - it does not seem that the palette is reverted back when the space changes to less than the threshold
Thanks @pino I will update revision soon
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D16353
To: sourabhboss, ngraham, pino, elvisangelaccio
Cc: kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181021/241526ea/attachment.htm>
More information about the kfm-devel
mailing list