D15980: Warn user before renaming the file/folder to start with a ' . '

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Almost there :)

INLINE COMMENTS

> dolphinview.cpp:1585
> +                const auto code = KMessageBox::questionYesNo(this,
> +                                                             oldItem.isFile() ? i18n("Adding a dot to the beginning of this file's name will hide it from view.\n"
> +                                                                                     "Do you still want to rename it?")

We should use semantic markup here (instead of hardcoding `\n`):

  xi18nc("@info", "Adding a dot to the beginning of this file's name will hide it from view.<nl/>"
                  "Do you still want to rename it?")

See https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup

> dolphinview.cpp:1587
> +                                                                                     "Do you still want to rename it?")
> +                                                                              : i18n("Adding a dot to the beginning of this folder's name will hide it from view.\n"
> +                                                                                     "Do you still want to rename it?"),

and also here.

> dolphinview.cpp:1593
> +                                                             QStringLiteral("ConfirmHide")
> +                                                            );
> +

Please move it at the end of previous line

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15980

To: shubham, elvisangelaccio, ngraham, pino
Cc: elvisangelaccio, pino, kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181020/eee4ce59/attachment.htm>