D16307: [KStandardItemListWidget] Pass icon state to overlay painter

Kai Uwe Broulik noreply at phabricator.kde.org
Sat Oct 20 08:19:08 BST 2018


broulik added a comment.


  > Not sure this is semantically correct. The fact that some emblems are white with no border is an implementation detail that Dolphin shouldn't have to care about.
  
  I agree, it's a separate issue, though, as I would have expected this codepath to also affect files with thumbnails but it does not, the overlays for thumbnails are painted in `KFileItemModelRolesUpdater::slotGotPreview` instead which doesn't have any notion of selected/hovered.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16307

To: broulik, #dolphin, #vdg, elvisangelaccio
Cc: ngraham, kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181020/38e71f99/attachment.htm>


More information about the kfm-devel mailing list