D15980: Warn user before renaming the file/folder to start with a ' . '

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinview.cpp:1592
> +                                                            KStandardGuiItem::cancel(),
> +                                                            QStringLiteral(":Do not ask again"),
> +                                                            KMessageBox::Notify);

Please use a more descriptive key string. It should be in CamelCase, for example "ConfirmHide" or similar.

Also, please remove the leading `:`. That will put the config key in `kdeglobals`, but this is a Dolphin-specific dialog and the config key should go in `dolphinrc` instead.

> dolphinview.cpp:1593
> +                                                            QStringLiteral(":Do not ask again"),
> +                                                            KMessageBox::Notify);
> +

This argument can be removed, it's already used as default.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15980

To: shubham, elvisangelaccio, broulik, ngraham, pino
Cc: elvisangelaccio, pino, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181014/2c54cb6f/attachment.htm>