D15609: Add "Create New" menu to "Control" button

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:863-870
> +    QMenu* createNewMenu = m_newFileMenu->menu();
> +    menu->addMenu(createNewMenu);
> +    menu->setTitle(i18nc("@title:menu Create new folder, file, link, etc.", "Create New"));
> +    menu->setIcon(QIcon::fromTheme(QStringLiteral("document-new")));
> +    connect(createNewMenu, &QMenu::aboutToShow,
> +            this, &DolphinMainWindow::updateNewMenu);
> +

Why duplicate the menu initialization? It's enough to use this one-liner:

  menu->addMenu(m_newFileMenu->menu());

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15609

To: ngraham, #dolphin, broulik, elvisangelaccio
Cc: acrouthamel, anthonyfieroni, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181007/8682fcea/attachment.htm>