D15980: Warn user before renaming the file/folder to start with a ' . '

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  Now that we're using a `KMessageBox::questionYesNo`, the "No" choice is now just the word "No", which we should avoid. Instead, the button's text should be "Cancel", and it should have the appropriate cancel icon. You can use a `KStandardGuiItem::cancel()` for this.
  
  I had another idea: instead of telling the user how to show hidden files inside the now somewhat crowded dialog box, we could show it as an inline message using `dolphinViewContainer::showMessage()`. Bonus points if you add Undo and/or Show Hidden Files button to the widget!

INLINE COMMENTS

> pino wrote in dolphinview.cpp:1593
> please fix the capitalization, see the HIG

Relevant section is https://hig.kde.org/style/writing/capitalization.html

> pino wrote in dolphinview.cpp:1586
> "item" here is still a string puzzle.

@pino, looks good to me now with the latest version of this diff.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15980

To: shubham, elvisangelaccio, broulik, ngraham, pino
Cc: pino, totto, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181006/61f028a3/attachment.htm>