D15929: Add a 'Properties' entry in the Places panel context menu

Christoph Feck noreply at phabricator.kde.org
Fri Oct 5 01:22:07 BST 2018


cfeck added a comment.


  There already is a separator (original line 202), but it is (for whatever reason) not always added. You can remove the `if` for the separator either in this commit, or in a separate patch, because it is unrelated to the addition of the `Properties` item.
  
  What I am trying to get fixed before you commit this is the placement of the new `Properties` item. Order should be:
  
    Open in Window
    Open in Tab
    (Properties)
    --------
    (Edit...)
    (Remove)
    Hide
    Hide Section
  
  If I understand your patch, currently the order would be:
  
    Open in Window
    Open in Tab
    --------
    (Edit...)
    (Properties)
    (Remove)
    Hide
    Hide Section
  
  (Items in parens are not always visible)
  
  I hope this clarifies the confusion I added by my previous comments.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15929

To: thsurrel, #dolphin, #plasma, #vdg
Cc: elvisangelaccio, cfeck, ngraham, abetts, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181005/7057cf68/attachment.htm>


More information about the kfm-devel mailing list