D17111: Do not sort twice when changing role and order at the same time

Thomas Surrel noreply at phabricator.kde.org
Thu Nov 22 21:30:34 GMT 2018


thsurrel created this revision.
thsurrel added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  When using the list header to change the role and order, if one
  changes the order to descending and then changes role, dolphin
  also changes the order back to ascending. This results in sorting
  the list of files twice in a row. This patch removes the first
  (useless) sort.

REPOSITORY
  R318 Dolphin

BRANCH
  arc_sort_optim (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17111

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp
  src/kitemviews/kfileitemmodel.h
  src/kitemviews/kitemmodelbase.cpp
  src/kitemviews/kitemmodelbase.h
  src/kitemviews/private/kitemlistheaderwidget.cpp

To: thsurrel, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181122/f15379e6/attachment.htm>


More information about the kfm-devel mailing list