D17088: [thumbnailer appimage] Fix building with libappimage not in system path
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Nov 22 00:38:48 GMT 2018
kossebau created this revision.
kossebau added reviewers: broulik, TheAssassin, azubieta.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
The current CMake Config file of libappimage does not specify any
imported target nameed "appimage". Instead it provides a shared lib
target "libappimage" and a static lib target "libappimage_static".
Both though are also broken in that they have targets to further
dependencies in their link list, which though are only defined in the
internal build system, but not provided with the installed CMake Config
file.
Additionally the LIBAPPIMAGE_INCLUDE_DIRS is currently not set,
https://github.com/AppImage/libappimage/pull/17 hopefully fixes this
for future versions.
The previous simple "appimage" only worked if libappimage was installed
to an otherwise known prefix, so include dirs and library paths were among
the ones considered, and the linker would find libappimage via -lappimage.
TEST PLAN
Building against current version of libappimage installed to custom prefix
works, as well as building against the patched version.
REPOSITORY
R320 KIO Extras
BRANCH
fixappimagelinking
REVISION DETAIL
https://phabricator.kde.org/D17088
AFFECTED FILES
thumbnail/CMakeLists.txt
To: kossebau, broulik, TheAssassin, azubieta
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181122/6715cd0b/attachment.htm>
More information about the kfm-devel
mailing list