D17063: Fix middle click on breadcrumbs, in split view

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Looks good beside the inline issue (hence why my Request Changes).
  
  But I have another proposal: what if middle-clicking on the inactive urlnavigator would toggle the active split view?
  We already do that if we middle-click the inactive view itself, or a folder in the inactive view.
  
  Thoughts?

INLINE COMMENTS

> dolphinmainwindow.cpp:974-975
>      if (oldViewContainer) {
>          // Disconnect all signals between the old view container (container,
>          // view and url navigator) and main window.
>          oldViewContainer->disconnect(this);

This comment should be updated too.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D17063

To: thsurrel, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181120/ca82e7a4/attachment.htm>