D17012: Hide the Rename context menu entry when impossible

Thomas Surrel noreply at phabricator.kde.org
Mon Nov 19 13:37:53 GMT 2018


thsurrel added a comment.


  'Delete' and 'Rename' entries are in the same section, but one gets disabled when the other one is hidden. I think they should behave the same way.
  But should we disable (but show) 'Delete' or hide 'Rename', I can fix the patch to go one way or the other.
  
  I agree it is usually better to only disable an entry that is not available. One argument in favor of hiding is that lot of things are already disabled usually in that situation (Cutting, Create new), it makes the context menu a bit cluttered.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D17012

To: thsurrel, #dolphin, #vdg
Cc: romangg, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181119/f8131392/attachment.htm>


More information about the kfm-devel mailing list