D16980: Return editable URL navigator to breadcrumb mode when it has focus and Ctrl+L is pressed
Nathaniel Graham
noreply at phabricator.kde.org
Sun Nov 18 15:48:16 GMT 2018
ngraham created this revision.
ngraham added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch makes an editable location bar return to breadcrumb mode when [Ctrl] + [L] is pressed, but only if the location bar currently has focus. Otherwise, it will simply return focus to it as before.
This provides a slightly easier way to make the location bar return to breadcrumbs mode
Bonus points: `KDirOperator` toggles editable/breadbrtumbs with [Ctrl] + [L] as well, so this improves consistency.
TEST PLAN
- Compile and deploy and make the location bar be breadcrumbs
- Hit [Ctrl] + [L] twice in a row -> location field should return to being breadcrumb mode
- Hit [Ctrl] + [L], move focus elsewhere, then hit [Ctrl] + [L] again -> Location bar should be editable and focused
REPOSITORY
R318 Dolphin
BRANCH
ctrl-l-can-close-urlnavigator (branched from Applications/18.12)
REVISION DETAIL
https://phabricator.kde.org/D16980
AFFECTED FILES
src/dolphinmainwindow.cpp
To: ngraham, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181118/8b94c3bf/attachment.htm>
More information about the kfm-devel
mailing list