D16896: move kcrash link to dolphin app (which is the effective user)

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
sitter requested review of this revision.

REVISION SUMMARY
  to successfully use kcrash when linking with as-needed (which is a default
  flag on many linux distros) one also needs to call KCrash::initialize.
  this call happens in the app's main.cpp. as such the kcrash link target
  on the dolphinprivate library doesn't do anything for dolphinprivate but
  only kicks into action for dolphin itself.
  to avoid confusion and make it clear that kcrash is only initialized in the
  application scope the KF5::Crash link target is now on the application
  target, not the library target.
  
  (this makes no difference in the output, kcrash was still correctly linked
   via dolphinprivate; but only for kdeinit_dolphin, dolphinprivate did
   not get linked to it with as-needed)

TEST PLAN
  builds; links as expected

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16896

AFFECTED FILES
  src/CMakeLists.txt

To: sitter, elvisangelaccio
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181115/dc3518ce/attachment.htm>