D16872: Add FileItemActionPlugin for tag manipulation

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Nice!
  
  It should to be possible to show the context menu entry for folders, too, since they can also be tagged.

INLINE COMMENTS

> tagsfileitemaction.cpp:43
> +{
> +    m_menu = new QMenu(i18n("Tags"));
> +    m_menu->setIcon(QIcon::fromTheme(QStringLiteral("tag")));

Can we change this to use an action verb?

Like "Assign Tags" or "Tag this Item" or something like that.

> tagsfileitemaction.cpp:71
> +
> +    QAction* newAction = new QAction(i18n("Create new"));
> +    newAction->setIcon(QIcon::fromTheme(QStringLiteral("tag")));

Needs to be in Title Case and have ellipses: "Create New..."

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D16872

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181114/2c6e5aa6/attachment.htm>