D16857: Do not disconnect all StorageAccess signals when unmounting

Thomas Surrel noreply at phabricator.kde.org
Tue Nov 13 10:11:29 GMT 2018


thsurrel created this revision.
thsurrel added reviewers: Dolphin, VDG.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  When unmounting a local device from the Places panel, the item
  was disconnected from all signals from Solid::StorageAccess.
  That resulted in a weird situation where trying again to access
  the device was actually mounting it in Solid, but dolphin just
  behaved as if nothing at all was happening.
  
  BUG: 400992

TEST PLAN
  In Dolphin, mount a local partition (e.g. a Windows partition)
  then unmount it (right click on it in Places, then Unmount).
  Try to access it again by clicking on it in Places, we should
  get access to it correctly.

REPOSITORY
  R318 Dolphin

BRANCH
  arc_remount_local (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16857

AFFECTED FILES
  src/panels/places/placesitemmodel.cpp

To: thsurrel, #dolphin, #vdg
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181113/36329bb9/attachment.htm>


More information about the kfm-devel mailing list